8000 < 8000 meta name="github-keyboard-shortcuts" content="repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot" data-turbo-transient="true" />
Skip to content

fix: Loop node no input data shown#10224

Merged
michael-radency merged 5 commits intomasterfrom
node-1533-schema-view-no-input-data-shown-for-first-node-after-a-loop
Jul 31, 2024
Merged

fix: Loop node no input data shown#10224
michael-radency merged 5 commits intomasterfrom
node-1533-schema-view-no-input-data-shown-for-first-node-after-a-loop

Conversation

@michael-radency
Copy link
Copy Markdown
Contributor

Summary

fix for:
Schema view: no input data shown for first node after a loop node
You can't switch to table/JSON view either.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1533/schema-view-no-input-data-shown-for-first-node-after-a-loop-node

โ€ฆschema-view-no-input-data-shown-for-first-node-after-a-loop
@michael-radency michael-radency added ui Enhancement in /editor-ui or /design-system n8n team Authored by the n8n team labels Jul 29, 2024
ShireenMissi
ShireenMissi previously approved these changes Jul 29, 2024
Copy link
Copy Markdown
Contributor
@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ๐ŸŽ‰

@github-actions
Copy link
Copy Markdown
Contributor

โœ… All Cypress E2E specs passed

@cypress
Copy link
Copy Markdown
cypress bot commented Jul 29, 2024



Test summary

390 โ€ข 0 โ€ข 0 โ€ข 0 โ€ข Flakiness 0


Run details

Project n8n
Status Passed
Commit 3bffd16
Started Jul 31, 2024 12:57 PM
Ended Jul 31, 2024 1:02 PM
Duration 04:46 ๐Ÿ’ก
OS Linux Debian -
Browser Electron 118

View run in Cypress Cloud โžก๏ธ


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Copy Markdown
Contributor
@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on Linear, this fix shouldn't be merged for now.

@ShireenMissi ShireenMissi dismissed their stale review July 30, 2024 09:51

As discussed on Linear, this fix shouldn't be merged for now.

โ€ฆschema-view-no-input-data-shown-for-first-node-after-a-loop
โ€ฆschema-view-no-input-data-shown-for-first-node-after-a-loop
Copy link
Copy Markdown
Contributor
@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ๐ŸŽ‰

@github-actions
Copy link
Copy Markdown
Contributor

โœ… All Cypress E2E specs passed

@michael-radency michael-radency merged commit c8ee852 into master Jul 31, 2024
@michael-radency michael-radency deleted the node-1533-schema-view-no-input-data-shown-for-first-node-after-a-loop branch July 31, 2024 13:11
MiloradFilipovic added a commit that referenced this pull request Jul 31, 2024
* master:
  feat(AWS Lambda Node): Add support for paired items (no-changelog) (#10270)
  fix: Loop node no input data shown (#10224)
  fix(core): Make OAuth1/OAuth2 callback not require auth (#10263)
  ๐Ÿš€ Release 1.53.0 (#10266)
  fix(core): Upgrade @n8n/vm2 to address CVEโ€‘2023โ€‘37466 (#10265)
  feat(Calendly Trigger Node): Add OAuth Credentials Support (#10251)
  test(core): Improve and expand log streaming tests (no-changelog) (#10261)
  refactor(editor): Migrate `WorkflowExecutionsListView.vue` to composition API (no-changelog) (#10198)
  fix(core): Restore log event `n8n.workflow.failed` (#10253)
  test(core): Stop showing JWT warning during test runs (no-changelog) (#10255)
MiloradFilipovic added a commit that referenced this pull request Aug 1, 2024
* master:
  refactor(core): Decouple workflow created, saved, deleted events from internal hooks (no-changelog) (#10264)
  fix(core): Fix oauth2 callback and add integration tests (no-changelog) (#10272)
  fix(n8n Form Trigger Node): Improve copy and a few tweaks (no-changelog) (#10243)
  fix(core): Fix expressions in webhook nodes(Form, Webhook) to access previous node's data (#10247)
  refactor(core): Port endpoints config (no-changelog) (#10268)
  feat(AWS Lambda Node): Add support for paired items (no-changelog) (#10270)
  fix: Loop node no input data shown (#10224)
  fix(core): Make OAuth1/OAuth2 callback not require auth (#10263)
  ๐Ÿš€ Release 1.53.0 (#10266)
  fix(core): Upgrade @n8n/vm2 to address CVEโ€‘2023โ€‘37466 (#10265)
  feat(Calendly Trigger Node): Add OAuth Credentials Support (#10251)
  test(core): Improve and expand log streaming tests (no-changelog) (#10261)
  refactor(editor): Migrate `WorkflowExecutionsListView.vue` to composition API (no-changelog) (#10198)
  fix(core): Restore log event `n8n.workflow.failed` (#10253)
  test(core): Stop showing JWT warning during test runs (no-changelog) (#10255)
  fix(Postgres Node): Expressions in query parameters for Postgres executeQuery operation (#10217)
  fix(editor): Fix workflow execution list scrolling after filter change (#10226)
despairblue pushed a commit that referenced this pull request Aug 2, 2024
@janober
Copy link
Copy Markdown
Member
janober commented Aug 2, 2024

Got released with n8n@1.53.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

3360
0