fix(core): Surface enterprise trial error message#10267
Conversation
There was a problem hiding this comment.
I'm not sure if surfacing license server error responses to the end user would solve anything, but I also don't see any issue with merging this as it is, and revisiting this later 👍🏽
| const errorMsg = | ||
| (error as AxiosError<{ message: string }>).response?.data?.message ?? error.message; | ||
|
|
||
| throw new BadRequestError(errorMsg); |
There was a problem hiding this comment.
This is relying on the error message that the license server returns. Maybe we should update the license server to return error codes, so that we can map those to human readable errors in this repo, instead of having to update the license server every time product wants to change the error that gets displayed.
There was a problem hiding this comment.
This is relying on the error message that the license server returns.
This is in a workflow, but I agree with the general principle.
|
✅ All Cypress E2E specs passed |
|
Test summaryRun details
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||||||||||
* master: refactor(core): Clean up event relays (no-changelog) (#10284) fix(editor): Fix execution retry button (#10275) feat(core): Show sub-node error on the logs pane. Open logs pane on sub-node error (#10248) refactor(core): Move instanceRole to InstanceSettings (no-changelog) (#10242) feat(core): Allow filtering executions and users by project in Public API (#10250) fix(core): Make execution and its data creation atomic (#10276) refactor(core): Mark schema env vars used by cloud hooks (no-changelog) (#10283) ci: Fix DB tests (no-changelog) (#10282) feat(core): Support create, delete, edit role for users in Public API (#10279) refactor(core): Decouple post workflow execute event from internal hooks (no-changelog) (#10280) feat(core): Allow transferring credentials in Public API (#10259) feat(core): Support create, read, update, delete projects in Public API (#10269) ci: Introduce lint rule `no-type-unsafe-event-emitter` (no-changelog) (#10254) fix(core): Surface enterprise trial error message (#10267) fix(editor): Enable moving resources only if team projects are available by the license (#10271) fix(core): Upgrade tournament to address some XSS vulnerabilities (#10277) # Conflicts: # packages/cli/src/Server.ts
|
Got released with |
https://linear.app/n8n/issue/PAY-1796