8000
Skip to content

feat(Code Node): Set defaultVersion to 2 for V1 RC builds (no-changelog)#6209

Merged
netroy merged 1 commit intomasterfrom
enable-python-in-v1-builds
May 9, 2023
Merged

feat(Code Node): Set defaultVersion to 2 for V1 RC builds (no-changelog)#6209
netroy merged 1 commit intomasterfrom
enable-python-in-v1-builds

Conversation

@netroy
Copy link
Copy Markdown
Contributor
@netroy netroy commented May 9, 2023

This will enable python in the Code node.

…elog)

This will enable python in the Code node.
@github-actions
Copy link
Copy Markdown
Contributor
github-actions bot commented May 9, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels May 9, 2023
@codecov
Copy link
Copy Markdown
codecov bot commented May 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7d1d1f7) 19.93% compared to head (ac45905) 19.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6209   +/-   ##
=======================================
  Coverage   19.93%   19.94%           
=======================================
  Files        2646     2647    +1     
  Lines      119664   119668    +4     
  Branches    18928    18929    +1     
=======================================
+ Hits        23859    23863    +4     
  Misses      95078    95078           
  Partials      727      727           
Impacted Files Coverage Δ
packages/nodes-base/nodes/Code/Code.node.ts 80.85% <100.00%> (+0.41%) ⬆️
packages/nodes-base/utils/constants.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Copy Markdown
Contributor
github-actions bot commented May 9, 2023

✅ All Cypress E2E specs passed

@netroy netroy merged commit 18b60c4 into master May 9, 2023
@netroy netroy deleted the enable-python-in-v1-builds branch May 9, 2023 15:28
MiloradFilipovic added a commit that referenced this pull request May 11, 2023
* master:
  feat(Google Ads Node): Update to support v13 (#6212)
  ci: Fix published nodes-base package's dependencies (no-changelog) (#6226)
  ci: Code coverage should include `.vue` files as well (no-changelog) (#6224)
  🚀 Release 0.228.0 (#6219)
  ci: Fix linting issue on master (no-changelog) (#6222)
  fix(core): Ensure DB repositories are initialized before the DB migrations are run  (#6220)
  refactor(editor): Stricter linting for promises and async functions (no-changelog) (#4642)
  ci: Increase timeout for DB tests (no-changelog) (#6221)
  fix(editor): Fix viewing and downloading of binary data (#6218)
  fix: Prevent unnecessary error messages also for data loaded flag (#6201)
  feat: Create NPM node (#6177)
  fix(editor): Fix polling trigger check for `runData` (#6130)
  ci: Fix linting issue on master (no-changelog) (#6217)
  fix: Prevent overflow when rendering expression hints (#6214)
  feat(core): Improve health check (#6205)
  refactor(editor): Add GitHub 30k stars banner (no-changelog) (#6204)
  fix(editor): Add loading skeletons to Executions list page (#6184)
  ci: Fix v1 docker rc builds (no-changelog) (#6208)
  feat(Code Node): Set `defaultVersion` to 2 for V1 RC builds (no-changelog) (#6209)
  fix: Correctly save executions that failed when polling as error instead of new (#6192)

# Conflicts:
#	packages/editor-ui/src/components/ParameterInputList.vue
@janober
Copy link
Copy Markdown
Member
janober commented May 25, 2023

Got released with n8n@0.228.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

n8n team Authored by the n8n team node/improvement New feature or request Released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0