8000
Skip to content

fix(core): Make sure that special polling parameters are available on community nodes as well#6230

Merged
netroy merged 1 commit intomasterfrom
polltimes-on-community-nodes
May 11, 2023
Merged

fix(core): Make sure that special polling parameters are available on community nodes as well#6230
netroy merged 1 commit intomasterfrom
polltimes-on-community-nodes

Conversation

@netroy
Copy link
Copy Markdown
Contributor
@netroy netroy commented May 11, 2023

This broke in 0.227.0.

… community nodes as well

This broke in 0.227.0.
@netroy netroy requested a review from Joffcom May 11, 2023 14:00
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels May 11, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@github-actions
Copy link
Copy Markdown
Contributor

✅ All Cypress E2E specs passed

@codecov
Copy link
Copy Markdown
codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (bd1bffc) 27.59% compared to head (9183010) 27.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6230      +/-   ##
==========================================
+ Coverage   27.59%   27.62%   +0.02%     
==========================================
  Files        2935     2938       +3     
  Lines      179761   179927     +166     
  Branches    19539    19543       +4     
==========================================
+ Hits        49612    49707      +95     
- Misses     129418   129489      +71     
  Partials      731      731              
Impacted Files Coverage Δ
packages/cli/src/NodeTypes.ts 50.00% <100.00%> (-3.85%) ⬇️
packages/cli/src/commands/BaseCommand.ts 52.11% <100.00%> (+0.68%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netroy netroy merged commit 9db49d0 into master May 11, 2023
@netroy netroy deleted the polltimes-on-community-nodes branch May 11, 2023 14:19
MiloradFilipovic added a commit that referenced this pull request May 12, 2023
* master:
  feat(editor): Version Control settings update (WIP) (#6233)
  ci: Fix linting issue on master (no-changelog) (#6232)
  fix: Prevent type error messages for manual executions (no-changelog) (#6229)
  fix(Code Node): Restore help text (#6231)
  fix(core): Make sure that special polling parameters are available on community nodes as well (#6230)
  feat(editor): Add color picker design system component (#6179)
  feat(Google Ads Node): Update to support v13 (#6212)
  ci: Fix published nodes-base package's dependencies (no-changelog) (#6226)
  ci: Code coverage should include `.vue` files as well (no-changelog) (#6224)
  🚀 Release 0.228.0 (#6219)
csuermann pushed a commit that referenced this pull request May 15, 2023
… community nodes as well (#6230)

This broke in 0.227.0.
netroy added a commit that referenced this pull request May 15, 2023
… community nodes as well (#6230)

This broke in 0.227.0.
@janober
Copy link
Copy Markdown
Member
janober commented May 25, 2023

Got released with n8n@0.228.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0