build(deps-dev): upgrade cosmiconfig to v8.3.6#211
Merged
LironEr merged 1 commit intoLironEr:mainfrom Aug 18, 2024
Merged
Conversation
Owner
|
Thank you for the PR! (: Please run |
Contributor
Author
|
@LironEr ugh, so sorry, I did that after I opened the PR and then forgot to push 🤦♂️ |
There should be no significant breaking changes by upgrading to v8 (https://github.com/cosmiconfig/cosmiconfig/blob/main/CHANGELOG.md#800) it just drops support for older versions of NodeJS. The benefit to this change will be supporting ESM by default: cosmiconfig/cosmiconfig#224
BundleMonUnchanged files (14)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
LironEr
approved these changes
Aug 18, 2024
Contributor
Author
|
@LironEr thanks for the quick ship! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There should be no significant breaking changes by upgrading to v8 (https://github.com/cosmiconfig/cosmiconfig/blob/main/CHANGELOG.md#800) it just drops support for older versions of NodeJS.
I'm trying to avoid new CommonJS files in my repo & the benefit to this change will be supporting ESM by default: cosmiconfig/cosmiconfig#224
However, there is a workaround with
resolutionsin mypackage.json:Note: there is a more recent major version of
cosmiconfig(https://github.com/cosmiconfig/cosmiconfig/blob/main/CHANGELOG.md#900) but since there are more significant breaking changes I elected to suggest v8.