fix(audio): list bluetooth microphones on linux - #424
Merged
Conversation
The pactl enumeration only kept sources whose device.class property was exactly "sound". PipeWire sets that property in its ALSA/udev path only, the bluez5 plugin never sets it, so every bluez_input.* source was dropped and Bluetooth headsets never showed up in the microphone list. Exclude monitor sources instead of requiring device.class = "sound". Sources without the property are now listed, which also covers virtual microphones such as NoiseTorch or echo-cancel.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bluetooth microphones (
bluez_input.*) never appeared in the microphone list on Linux because the pactl enumeration requireddevice.class = "sound", a property that only PipeWire's ALSA/udev path sets. The filter now excludes monitor sources instead, so sources withoutdevice.class(Bluetooth, and virtual microphones such as NoiseTorch or echo-cancel) are listed. Note: this was not tested manually, there is no Bluetooth headset available on the machine used for this change.Fixes #421
Type of change
Tested on
Checklist
cargo clippyandcargo fmt(if Rust changes)