test: rename system tests from SystemTest suite to per-plugin suites - #2843
Merged
Conversation
Split the monolithic SystemTest suite into per-plugin/area suites so tests appear as e.g. Ftp.UploadFile instead of SystemTest.FtpUploadFile. Mapping: Action, Camera, ComponentMetadata, Connections, Ftp, Geofence, Intercept, MavlinkDirect, MavlinkSeq, Mission, Param, RawBytes, Telemetry Part of v4 plan: mavlink#2830 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Drop redundant Test/Tests suffix from fixture class names:
CurlTest -> Curl (strip Curl_ prefix from test case names)
FileCacheTest -> FileCache (rename snake_case_test -> PascalCase)
HttpLoaderTest -> HttpLoader (strip HttpLoader_ prefix from test cases)
MavlinkMissionTransferClientTest -> MavlinkMissionTransferClient
MavlinkMissionTransferClientNackTests -> MavlinkMissionTransferClientNack
MavlinkMissionTransferServerNackTests -> MavlinkMissionTransferServerNack
MissionTypeParameterTest -> MavlinkMissionTransferServer
- Fix Geoemtry typo -> Geometry
Part of v4 plan: mavlink#2830
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Renaming the fixture class to HttpLoader conflicted with the production class of the same name pulled in by 'using namespace mavsdk;'. Rename it to HttpLoaderFixture to avoid the ambiguity. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Rename test fixture from FileCache to FileCacheFixture to avoid ambiguity with mavsdk::FileCache when using namespace mavsdk.
Fix line length and indentation issues flagged by the CI style checker: - mavlink_mission_transfer_client_test.cpp: join short TEST_F macros back onto single lines (line length fits within limit) - mavlink_mission_transfer_server_test.cpp: fix WithParamInterface alignment and split overlong TEST_P macro names onto two lines Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ent/Server Rename test fixture classes to avoid ambiguity with the mavsdk-namespace classes after `using namespace mavsdk`: - mavlink_mission_transfer_client_test.cpp: MavlinkMissionTransferClient → MavlinkMissionTransferClientTest - mavlink_mission_transfer_server_test.cpp: MavlinkMissionTransferServer → MavlinkMissionTransferServerFixture Also apply clang-format to TEST_F/TEST_P macros whose names now exceed the line-length limit due to the longer fixture names. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
julianoes
approved these changes
Apr 4, 2026
bansiesta
added a commit
to bansiesta/MAVSDK
that referenced
this pull request
Apr 20, 2026
…avlink#2843) * test: rename system tests from SystemTest suite to per-plugin suites Split the monolithic SystemTest suite into per-plugin/area suites so tests appear as e.g. Ftp.UploadFile instead of SystemTest.FtpUploadFile. Mapping: Action, Camera, ComponentMetadata, Connections, Ftp, Geofence, Intercept, MavlinkDirect, MavlinkSeq, Mission, Param, RawBytes, Telemetry Part of v4 plan: mavlink#2830 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test: clean up unit test suite names - Drop redundant Test/Tests suffix from fixture class names: CurlTest -> Curl (strip Curl_ prefix from test case names) FileCacheTest -> FileCache (rename snake_case_test -> PascalCase) HttpLoaderTest -> HttpLoader (strip HttpLoader_ prefix from test cases) MavlinkMissionTransferClientTest -> MavlinkMissionTransferClient MavlinkMissionTransferClientNackTests -> MavlinkMissionTransferClientNack MavlinkMissionTransferServerNackTests -> MavlinkMissionTransferServerNack MissionTypeParameterTest -> MavlinkMissionTransferServer - Fix Geoemtry typo -> Geometry Part of v4 plan: mavlink#2830 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test: fix HttpLoaderFixture name clash with mavsdk::HttpLoader Renaming the fixture class to HttpLoader conflicted with the production class of the same name pulled in by 'using namespace mavsdk;'. Rename it to HttpLoaderFixture to avoid the ambiguity. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test: fix FileCacheFixture name clash with mavsdk::FileCache Rename test fixture from FileCache to FileCacheFixture to avoid ambiguity with mavsdk::FileCache when using namespace mavsdk. * style: fix clang-format issues in mission transfer test files Fix line length and indentation issues flagged by the CI style checker: - mavlink_mission_transfer_client_test.cpp: join short TEST_F macros back onto single lines (line length fits within limit) - mavlink_mission_transfer_server_test.cpp: fix WithParamInterface alignment and split overlong TEST_P macro names onto two lines Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test: fix fixture name clashes with mavsdk::MavlinkMissionTransferClient/Server Rename test fixture classes to avoid ambiguity with the mavsdk-namespace classes after `using namespace mavsdk`: - mavlink_mission_transfer_client_test.cpp: MavlinkMissionTransferClient → MavlinkMissionTransferClientTest - mavlink_mission_transfer_server_test.cpp: MavlinkMissionTransferServer → MavlinkMissionTransferServerFixture Also apply clang-format to TEST_F/TEST_P macros whose names now exceed the line-length limit due to the longer fixture names. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of v4 plan: #2830.
Splits the monolithic
SystemTestsuite into 13 per-plugin/area suites so tests appear as e.g.Ftp.UploadFileinstead ofSystemTest.FtpUploadFile.New suites:
Action,Camera,ComponentMetadata,Connections,Ftp,Geofence,Intercept,MavlinkDirect,MavlinkSeq,Mission,Param,RawBytes,Telemetry.All 83 tests renamed, purely mechanical change.
🤖 Generated with Claude Code