Patch rules_graalvm for Bazel 9#28014
Closed
meteorcloudy wants to merge 1 commit intobazelbuild:masterfrom
Closed
Conversation
There was a problem hiding this comment.
Code Review
This pull request patches rules_graalvm to be compatible with Bazel 9 by adding a new patch file, rules_graalvm_bazel9_fixes.patch. The patch correctly adds necessary load statements to various BUILD and .bzl files. My feedback includes one suggestion to improve the maintainability of these patches.
| "//third_party:rules_graalvm_fix.patch", | ||
| "//third_party:rules_graalvm_unicode.patch", | ||
| "//third_party:rules_graalvm_load_fix.patch", | ||
| "//third_party:rules_graalvm_bazel9_fixes.patch", |
There was a problem hiding this comment.
For better maintainability, consider combining this new patch with //third_party:rules_graalvm_load_fix.patch. Both patches address similar issues (adding load statements for Bazel compatibility) and even modify the same file (internal/native_image/rules.bzl). Consolidating related fixes into a single patch makes the set of applied changes easier to understand and manage in the long term.
Wyverald
pushed a commit
that referenced
this pull request
Jan 21, 2026
Closes #28014. PiperOrigin-RevId: 845680411 Change-Id: I4454ed2731b24ec051ee633460e8bb120fb07d04
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Mar 5, 2026
Closes bazelbuild#28014. PiperOrigin-RevId: 845680411 Change-Id: I4454ed2731b24ec051ee633460e8bb120fb07d04
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 6, 2026
Closes #28014. PiperOrigin-RevId: 845680411 Change-Id: I4454ed2731b24ec051ee633460e8bb120fb07d04 <!-- Thank you for contributing to Bazel! Please read the contribution guidelines: https://bazel.build/contribute.html --> ### Description <!-- Please provide a brief summary of the changes in this PR. --> ### Motivation <!-- Why is this change important? Does it fix a specific bug or add a new feature? If this PR fixes an existing issue, please link it here (e.g. "Fixes #1234"). --> ### Build API Changes <!-- Does this PR affect the Build API? (e.g. Starlark API, providers, command-line flags, native rules) If yes, please answer the following: 1. Has this been discussed in a design doc or issue? (Please link it) 2. Is the change backward compatible? 3. If it's a breaking change, what is the migration plan? --> No ### Checklist - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes <!-- If this is a new feature, please add 'RELNOTES[NEW]: <description>' here. If this is a breaking change, please add 'RELNOTES[INC]: <reason>' here. If this change should be mentioned in release notes, please add 'RELNOTES: <reason>' here. --> RELNOTES: None Commit: f0ec350 Co-authored-by: Yun Peng <pcloudy@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.