test(cli-e2e): add create-sanity E2E tests and package manager validation#882
Draft
test(cli-e2e): add create-sanity E2E tests and package manager validation#882
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Claude finished @binoy14's task in 1m 13s —— View job Review
No changeset required — this is a tests-only/E2E infrastructure PR with no runtime behavior changes. Correct that none was added. 1. Missing The PR description states "Add E2E tests for 2. describe.skipIf(!version)('create-sanity via package managers', () => {
const managers = getAvailablePackageManagers() // runs execFileSync calls hereVitest evaluates the |
This was referenced Apr 3, 2026
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (052fecb) |
|---|---|---|
| Internal (raw) | 2.1 KB | - |
| Internal (gzip) | 799 B | - |
| Bundled (raw) | 10.94 MB | - |
| Bundled (gzip) | 2.05 MB | - |
| Import time | 833ms | +5ms, +0.6% |
bin:sanity
| Metric | Value | vs main (052fecb) |
|---|---|---|
| Internal (raw) | 975 B | - |
| Internal (gzip) | 460 B | - |
| Bundled (raw) | 9.84 MB | - |
| Bundled (gzip) | 1.77 MB | - |
| Import time | 2.00s | +14ms, +0.7% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-core
Compared against main (052fecb8)
| Metric | Value | vs main (052fecb) |
|---|---|---|
| Internal (raw) | 93.1 KB | - |
| Internal (gzip) | 21.9 KB | - |
| Bundled (raw) | 21.62 MB | - |
| Bundled (gzip) | 3.42 MB | - |
| Import time | 791ms | +1ms, +0.1% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — create-sanity
Compared against main (052fecb8)
| Metric | Value | vs main (052fecb) |
|---|---|---|
| Internal (raw) | 976 B | - |
| Internal (gzip) | 507 B | - |
| Bundled (raw) | 50.7 KB | - |
| Bundled (gzip) | 12.6 KB | - |
| Import time | ❌ ChildProcess denied: node | - |
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
Contributor
Coverage DeltaNo covered files changed in this PR. Overall Coverage
|
c518521 to
f34b3cd
Compare
fd19674 to
a3deeb0
Compare
f34b3cd to
62ac2ba
Compare
a3deeb0 to
877efba
Compare
62ac2ba to
db4435a
Compare
877efba to
26ef7cf
Compare
db4435a to
b3b94fe
Compare
26ef7cf to
f243fac
Compare
f243fac to
d5b0583
Compare
b3b94fe to
62c844d
Compare
d5b0583 to
ddf075b
Compare
5d35621 to
ccd048e
Compare
ddf075b to
4be460e
Compare
ccd048e to
c757807
Compare
4be460e to
05e393f
Compare
c757807 to
65e519a
Compare
05e393f to
410dba8
Compare
65e519a to
03df826
Compare
c3d6b70 to
c1128c1
Compare
03df826 to
4bd2b75
Compare
c1128c1 to
d74b2f2
Compare
0fe1bf7 to
c97d989
Compare
d74b2f2 to
55da18a
Compare
8b04e9a to
28b41c5
Compare
55da18a to
8d3b3f3
Compare
5bf99ce to
c2a1691
Compare
8d3b3f3 to
a511a4c
Compare
c2a1691 to
cd46239
Compare
a511a4c to
3dc48c9
Compare
…tion Generalize packCli into packPackage to support packing multiple packages, add binaryPath option to runCli, and add E2E tests for create-sanity and package manager detection/validation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3dc48c9 to
43b2495
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packCli()intopackPackage(name)so any workspace package can be packed for E2E testingglobalSetupto pack and installcreate-sanityalongside@sanity/clibinaryPathoption torunCli()so tests can target any installed binarycreate-sanity --helpand--versionnpm create sanity@<version>,pnpm create sanity@<version>, andyarn dlx create-sanity@<version>work correctlyTest plan
pnpm check:types --filter=@sanity/cli-e2epassespnpm lintpasses for cli-e2ecreate-sanity --helpE2E test passescreate-sanity --versionE2E test passeshelp.test.ts,datasetsList.test.ts) still passCloses SDK-1195
🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com