8000
Skip to content

Binary .solb writers corrupt multi-solution round trips #326

Description

@kmarchais

MMG3D_saveAllSols corrupts .solb files on v5.8.0 and current master (8ed2259). After reloading, only the first vertex is correct; subsequent values are misaligned.

The writer emits an ASCII newline after every record, including in binary mode:

MMG5_writeDoubleSol3D(mesh, psl, inm, bin, k, 0);
fprintf(inm, "\n");

This shifts the binary stream. MMG2D_saveAllSols and MMGS_saveAllSols contain the same pattern.

Expected: write the newline only when !bin and add a binary round-trip test.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    0