8000
Skip to content

Fix docs unnecessarily undergo limbo resolution while resuming query bug - #5506

Merged
milaGGL merged 11 commits into
masterfrom
mila/fix-limbo-bug
Nov 21, 2023
Merged

Fix docs unnecessarily undergo limbo resolution while resuming query bug#5506
milaGGL merged 11 commits into
masterfrom
mila/fix-limbo-bug

Conversation

@milaGGL
@milaGGL milaGGL commented Nov 2, 2023 •
edited
Loading
Copy link
Copy Markdown
Contributor

@github-actions
github-actions Bot commented Nov 2, 2023 •
edited
Loading
Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@github-actions
github-actions Bot commented Nov 2, 2023 •
edited
Loading
Copy link
Copy Markdown
Contributor

Unit Test Results

   180 files  +   177     180 suites  +177   3m 37s ⏱️ + 3m 25s
1 222 tests +1 203  1 206 ✔️ +1 187  16 💤 +16  0 ❌ ±0 
2 468 runs  +2 449  2 436 ✔️ +2 417  32 💤 +32  0 ❌ ±0 

Results for commit 9189965. ± Comparison against base commit 8a7621b.

This pull request removes 19 and adds 1222 tests. Note that renamed tests count towards both. 
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testconvertInputStreamToString_worksSuccessfully
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsNullWhenUuidIsNull
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsProperBytes
…

com.google.firebase.TimestampTest ‑ testCompare
com.google.firebase.TimestampTest ‑ testFromDate
com.google.firebase.TimestampTest ‑ testRejectBadDates
com.google.firebase.TimestampTest ‑ testTimestampParcelable
com.google.firebase.firestore.AggregateQuerySnapshotTest ‑ createWithCountShouldReturnInstanceWithTheGivenQueryAndCount
com.google.firebase.firestore.AggregateQueryTest ‑ testSourceMustNotBeNull
com.google.firebase.firestore.BlobTest ‑ testComparison
com.google.firebase.firestore.BlobTest ‑ testEquals
com.google.firebase.firestore.BlobTest ‑ testMutableBytes
com.google.firebase.firestore.CollectionReferenceTest ‑ testEquals
…

♻️ This comment has been updated with latest results.

@google-oss-bot
google-oss-bot commented Nov 2, 2023 •
edited
Loading
Copy link
Copy Markdown
Collaborator

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (8a7621b)Merge (adb338b)Diff
    aar1.41 MB1.41 MB+159 B (+0.0%)
    apk (release)11.2 MB11.2 MB+132 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yjDybxLvby.html

@google-oss-bot
google-oss-bot commented Nov 2, 2023 •
edited
Loading
Copy link
Copy Markdown
Collaborator

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentile8a7621badb338bDiffSignificant (?)
    p10470 ±233 μs417 ±208 μs-53.0 μs (-11.3%)NO
    p25485 ±236 μs435 ±207 μs-50.2 μs (-10.4%)NO
    p50515 ±241 μs483 ±198 μs-32.2 μs (-6.2%)NO
    p75573 ±234 μs561 ±182 μs-11.9 μs (-2.1%)NO
    p90641 ±220 μs702 ±208 μs+61.5 μs (+9.6%)NO

    20 test runs in comparison
    CommitTest Runs
    8a7621b
    • 2023-11-17_03:58:16.785409_xgZQ
    • 2023-11-17_03:58:16.785445_tHTY
    • 2023-11-17_03:58:16.785456_kFmq
    • 2023-11-17_03:58:16.785464_wTNg
    • 2023-11-17_03:58:16.785469_OBOn
    • 2023-11-17_03:58:16.785474_BTcR
    • 2023-11-17_03:58:16.785478_Sjdv
    • 2023-11-17_03:58:16.785482_MaMp
    • 2023-11-17_03:58:16.785486_ztcT
    • 2023-11-17_03:58:16.785490_fNCE
    adb338b
    • 2023-11-20_16:37:42.894783_qviA
    • 2023-11-20_16:37:42.894814_WFsi
    • 2023-11-20_16:37:42.894821_fEXX
    • 2023-11-20_16:37:42.894825_UiQy
    • 2023-11-20_16:37:42.894830_TFMH
    • 2023-11-20_16:37:42.894835_Zcdv
    • 2023-11-20_16:37:42.894839_IGwi
    • 2023-11-20_16:37:42.894843_NWoM
    • 2023-11-20_16:37:42.894851_BzYI
    • 2023-11-20_16:37:42.894860_GDLS
    redfin-30
    Percentile8a7621badb338bDiffSignificant (?)
    p10757 ±247 μs759 ±260 μs+1.92 μs (+0.3%)NO
    p25775 ±244 μs779 ±258 μs+3.80 μs (+0.5%)NO
    p50803 ±239 μs812 ±252 μs+8.23 μs (+1.0%)NO
    p75878 ±258 μs850 ±248 μs-27.8 μs (-3.2%)NO
    p90931 ±265 μs902 ±245 μs-28.3 μs (-3.0%)NO

    20 test runs in comparison
    CommitTest Runs
    8a7621b
    • 2023-11-17_03:58:16.785409_xgZQ
    • 2023-11-17_03:58:16.785445_tHTY
    • 2023-11-17_03:58:16.785456_kFmq
    • 2023-11-17_03:58:16.785464_wTNg
    • 2023-11-17_03:58:16.785469_OBOn
    • 2023-11-17_03:58:16.785474_BTcR
    • 2023-11-17_03:58:16.785478_Sjdv
    • 2023-11-17_03:58:16.785482_MaMp
    • 2023-11-17_03:58:16.785486_ztcT
    • 2023-11-17_03:58:16.785490_fNCE
    adb338b
    • 2023-11-20_16:37:42.894783_qviA
    • 2023-11-20_16:37:42.894814_WFsi
    • 2023-11-20_16:37:42.894821_fEXX
    • 2023-11-20_16:37:42.894825_UiQy
    • 2023-11-20_16:37:42.894830_TFMH
    • 2023-11-20_16:37:42.894835_Zcdv
    • 2023-11-20_16:37:42.894839_IGwi
    • 2023-11-20_16:37:42.894843_NWoM
    • 2023-11-20_16:37:42.894851_BzYI
    • 2023-11-20_16:37:42.894860_GDLS

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile8a7621badb338bDiffSignificant (?)
    p10203 ±3 ms207 ±2 ms+3.98 ms (+2.0%)NO
    p25209 ±3 ms212 ±2 ms+3.28 ms (+1.6%)NO
    p50217 ±3 ms220 ±2 ms+3.40 ms (+1.6%)NO
    p75225 ±3 ms230 ±3 ms+5.61 ms (+2.5%)NO
    p90233 ±3 ms245 ±8 ms+11.3 ms (+4.8%)NO

    20 test runs in comparison
    CommitTest Runs
    8a7621b
    • 2023-11-17_03:58:16.785409_xgZQ
    • 2023-11-17_03:58:16.785445_tHTY
    • 2023-11-17_03:58:16.785456_kFmq
    • 2023-11-17_03:58:16.785464_wTNg
    • 2023-11-17_03:58:16.785469_OBOn
    • 2023-11-17_03:58:16.785474_BTcR
    • 2023-11-17_03:58:16.785478_Sjdv
    • 2023-11-17_03:58:16.785482_MaMp
    • 2023-11-17_03:58:16.785486_ztcT
    • 2023-11-17_03:58:16.785490_fNCE
    adb338b
    • 2023-11-20_16:37:42.894783_qviA
    • 2023-11-20_16:37:42.894814_WFsi
    • 2023-11-20_16:37:42.894821_fEXX
    • 2023-11-20_16:37:42.894825_UiQy
    • 2023-11-20_16:37:42.894830_TFMH
    • 2023-11-20_16:37:42.894835_Zcdv
    • 2023-11-20_16:37:42.894839_IGwi
    • 2023-11-20_16:37:42.894843_NWoM
    • 2023-11-20_16:37:42.894851_BzYI
    • 2023-11-20_16:37:42.894860_GDLS
    redfin-30
    Percentile8a7621badb338bDiffSignificant (?)
    p10247 ±5 ms273 ±4 ms+25.5 ms (+10.3%)YES
    p25253 ±5 ms280 ±4 ms+26.2 ms (+10.3%)YES
    p50261 ±4 ms288 ±4 ms+26.9 ms (+10.3%)YES
    p75270 ±5 ms299 ±5 ms+28.5 ms (+10.5%)YES
    p90279 ±7 ms314 ±9 ms+34.7 ms (+12.4%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    8a7621b
    • 2023-11-17_03:58:16.785409_xgZQ
    • 2023-11-17_03:58:16.785445_tHTY
    • 2023-11-17_03:58:16.785456_kFmq
    • 2023-11-17_03:58:16.785464_wTNg
    • 2023-11-17_03:58:16.785469_OBOn
    • 2023-11-17_03:58:16.785474_BTcR
    • 2023-11-17_03:58:16.785478_Sjdv
    • 2023-11-17_03:58:16.785482_MaMp
    • 2023-11-17_03:58:16.785486_ztcT
    • 2023-11-17_03:58:16.785490_fNCE
    adb338b
    • 2023-11-20_16:37:42.894783_qviA
    • 2023-11-20_16:37:42.894814_WFsi
    • 2023-11-20_16:37:42.894821_fEXX
    • 2023-11-20_16:37:42.894825_UiQy
    • 2023-11-20_16:37:42.894830_TFMH
    • 2023-11-20_16:37:42.894835_Zcdv
    • 2023-11-20_16:37:42.894839_IGwi
    • 2023-11-20_16:37:42.894843_NWoM
    • 2023-11-20_16:37:42.894851_BzYI
    • 2023-11-20_16:37:42.894860_GDLS

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/z7dhbe7TMA/index.html

@google-oss-bot
google-oss-bot commented Nov 2, 2023 •
edited
Loading
Copy link
Copy Markdown
Collaborator

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.75% (8a7621b) to 44.76% (adb338b) by +0.01%.

    FilenameBase (8a7621b)Merge (adb338b)Diff
    SyncEngine.java93.31%93.38%+0.06%
    View.java96.79%96.82%+0.02%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ySExgUtsZR.html

@milaGGL
milaGGL requested a review from dconeybe November 14, 2023 15:04
@milaGGL milaGGL assigned milaGGL and dconeybe and unassigned milaGGL Nov 14, 2023
@dconeybe dconeybe mentioned this pull request Nov 16, 2023
Merged
4 tasks
dconeybe
dconeybe approved these changes Nov 16, 2023
View reviewed changes
@dconeybe dconeybe left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

@dconeybe dconeybe assigned milaGGL and unassigned dconeybe Nov 16, 2023
dconeybe
dconeybe requested changes Nov 16, 2023
View reviewed changes
@dconeybe dconeybe left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, please add a change log entry.

@milaGGL
milaGGL requested a review from dconeybe November 20, 2023 20:49
@milaGGL
milaGGL merged commit a014114 into master Nov 21, 2023
@milaGGL
milaGGL deleted the mila/fix-limbo-bug branch November 21, 2023 18:15
@firebase firebase locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@milaGGL milaGGL

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@milaGGL @google-oss-bot @dconeybe
0