8000
Skip to content

feat(locale): add 060 Japanese mobile phone number formats - #3922

Merged
ST-DDT merged 1 commit into
faker-js:nextfrom
noritaka1166:feat/ja-mobile-060-phone-numbers
Jun 30, 2026
Merged

feat(locale): add 060 Japanese mobile phone number formats#3922
ST-DDT merged 1 commit into
faker-js:nextfrom
noritaka1166:feat/ja-mobile-060-phone-numbers

Conversation

@noritaka1166
@noritaka1166 noritaka1166 commented Jun 28, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor
  • Add Japanese mobile phone number formats for the new 060-1 through 060-9 ranges to phone_number.format.mobile.

Source: https://www.soumu.go.jp/main_sosiki/joho_tsusin/top/tel_number/060keitai.html

@noritaka1166
noritaka1166 requested a review from a team as a code owner June 28, 2026 14:09
@netlify
netlify Bot commented Jun 28, 2026 •
edited
Loading
Copy link
Copy Markdown

✅ Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c22d33a
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/6a412f7e7c15980008a89291
😎 Deploy Preview https://deploy-preview-3922.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
codecov Bot commented Jun 28, 2026 •
edited
Loading
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.84%. Comparing base (fd33b72) to head (c22d33a).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #3922      +/-   ##
==========================================
- Coverage   98.85%   98.84%   -0.01%     
==========================================
  Files         923      923              
  Lines        3224     3216       -8     
  Branches      591      583       -8     
==========================================
- Hits         3187     3179       -8     
  Misses         33       33              
  Partials        4        4

see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matthewmayer
matthewmayer commented Jun 28, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor

Don't think it's necessary to touch the legacy cell_phone definitions since these will get removed in the next major version.

Shinigami92
Shinigami92 previously approved these changes Jun 28, 2026
View reviewed changes
@matthewmayer
matthewmayer commented Jun 28, 2026
Copy link
Copy Markdown
Contributor

I think the test is not really necessary either.

@noritaka1166
noritaka1166 force-pushed the feat/ja-mobile-060-phone-numbers branch from dc8bf56 to c22d33a Compare June 28, 2026 14:28
@Shinigami92
Shinigami92 commented Jun 28, 2026
Copy link
Copy Markdown
Member

I'm ok with letting this into our last planned v10.6 before we start v11.

@noritaka1166
noritaka1166 commented Jun 28, 2026
Copy link
Copy Markdown
Contributor Author

Don't think it's necessary to touch the legacy cell_phone definitions since these will get removed in the next major version.

Good point, thanks. I removed the changes to the legacy cell_phone definitions and kept this scoped to phone_number.format.mobile.

@noritaka1166
noritaka1166 commented Jun 28, 2026
Copy link
Copy Markdown
Contributor Author

I think the test is not really necessary either.

Makes sense. I removed the test as well and kept the PR to just the locale data update.

@ST-DDT
ST-DDT requested a review from Copilot June 28, 2026 20:00
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: phone Something is referring to the phone module labels Jun 28, 2026
@ST-DDT ST-DDT added this to the v10.x milestone Jun 28, 2026
Copilot AI reviewed Jun 28, 2026
View reviewed changes
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds newly allocated Japanese mobile number ranges in the ja locale so generated mobile numbers can include the 060-1 through 060-9 prefixes (per MIC guidance), expanding realism for JP mobile/M2M-style numbers.

Changes:

  • Expand phone_number.format.mobile for ja to include 0601####### through 0609#######.
  • Keep existing 070/080/090 mobile formats unchanged.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ST-DDT
ST-DDT approved these changes Jun 28, 2026
View reviewed changes
@ST-DDT ST-DDT left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT there aren't valid yet, but may become valid starting July 2026.

@ST-DDT
ST-DDT added this pull request to the merge queue Jun 30, 2026
Merged via the queue into faker-js:next with commit afa272d Jun 30, 2026
28 checks passed
@noritaka1166
noritaka1166 deleted the feat/ja-mobile-060-phone-numbers branch July 1, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@matthewmayer matthewmayer matthewmayer approved these changes
@ST-DDT ST-DDT ST-DDT approved these changes
@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@noritaka1166 noritaka1166

Labels

c: locale Permutes locale definitions m: phone Something is referring to the phone module p: 1-normal Nothing urgent

Projects

None yet

Milestone

v10.x

Development

Successfully merging this pull request may close these issues.

5 participants

@noritaka1166 @matthewmayer @Shinigami92 @ST-DDT
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0