asynpool: Don't return from inside a finally block #10000
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10000 +/- ##
==========================================
- Coverage 78.68% 78.67% -0.01%
==========================================
Files 153 153
Lines 19328 19330 +2
Branches 2221 2221
==========================================
Hits 15208 15208
- Misses 3822 3824 +2
Partials 298 298
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a Python 3.14 compatibility issue by removing a return statement from inside a finally block in the _flush_outqueue method. In Python 3.14, returning from within a finally block can cause problems and is discouraged. The fix maintains the necessary side effect (calling remove(fd)) while eliminating the problematic return.
- Removes
returnkeyword fromfinallyblock exception handler in_flush_outqueue
This commit makes the logic of the AsynPool class backwards compatible, except for one change related to exception handling. Before, if an exception **other than `(OSError, EOFError)`** was raised, it would be swallowed by the return inside of the finally block. Now, such an exception would propagate out of this method.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
auvipy
approved these changes
Nov 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple fix for the Python 3.14 issue mentioned in this discussion. Simply omit the
returnkeyword inside of the finally block.