8000
Skip to content
/ curl Public
  • < 8000 a href="/login?return_to=%2Fcurl%2Fcurl" rel="nofollow" id="repository-details-watch-button" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"notification subscription menu watch","repository_id":null,"auth_type":"LOG_IN","originating_url":"https://github.com/curl/curl/pull/6077","user_id":null}}" data-hydro-click-hmac="d211c6cf5782602c115cfc0039298974838c17ab5a71ec273aea81ae13fbedbd" aria-label="You must be signed in to change notification settings" data-view-component="true" class="btn-sm btn"> Notifications You must be signed in to change notification settings
  • Fork 7.3k
  • Star 42.7k

travis: use ninja-build for CMake builds - #6077

Merged
snikulov merged 1 commit into
curl:masterfrom
snikulov:travisci_cmake_use_ninja
Nov 4, 2020
Merged

travis: use ninja-build for CMake builds#6077
snikulov merged 1 commit into
curl:masterfrom
snikulov:travisci_cmake_use_ninja

Conversation

@snikulov
@snikulov snikulov commented Oct 14, 2020
Copy link
Copy Markdown
Contributor

Added package ninja-build to TravisCI environment
Use ninja to speed up CMake builds

Should speed up build a bit.

@snikulov snikulov added build cmake CI Continuous Integration labels Oct 14, 2020
@snikulov
snikulov force-pushed the travisci_cmake_use_ninja branch from c1bf77d to 19776f7 Compare October 14, 2020 13:56
@snikulov
snikulov requested review from bagder, jay and mback2k October 15, 2020 05:25
mback2k
mback2k approved these changes Oct 16, 2020
View reviewed changes
@mback2k mback2k left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, but now we won't be testing CMake generating classic Makefiles for us anymore, right?

@snikulov
snikulov commented Oct 16, 2020 •
edited
Loading
Copy link
Copy Markdown
Contributor Author

@mback2k yes. I think such tests should be done by CMake guys.
I'm still wondering why BoringSSL been built twice.
But I leave it as it was for Makefiles.
Thought maybe someone will shed some light on this...

@mback2k
mback2k requested a review from MarcelRaad October 19, 2020 06:07
@snikulov
travis: use ninja-build for CMake builds
8891805 
Added package ninja-build to environment
Use ninja to speed up CMake builds

Closes curl#6077
@snikulov
snikulov force-pushed the travisci_cmake_use_ninja branch from 19776f7 to 8891805 Compare November 3, 2020 17:51
@snikulov
snikulov merged commit e41ba40 into curl:master Nov 4, 2020
@snikulov
snikulov commented Nov 4, 2020
Copy link
Copy Markdown
Contributor Author

merged as e41ba40

@snikulov
snikulov deleted the travisci_cmake_use_ninja branch November 4, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bagder bagder bagder approved these changes
@mback2k mback2k mback2k approved these changes
@MarcelRaad MarcelRaad MarcelRaad approved these changes
@jay jay Awaiting requested review from jay

Assignees

No one assigned

Labels

build CI Continuous Integration cmake

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@snikulov @bagder @mback2k @MarcelRaad
0